add device_hub to python api - #14239
Merged
Nir-Az merged 3 commits intoAug 26, 2025
Merged
Conversation
Noy-Zini
force-pushed
the
add-device_hub-to-python-api
branch
from
August 25, 2025 08:45
3340333 to
0298e2e
Compare
Nir-Az
reviewed
Aug 25, 2025
Nir-Az
reviewed
Aug 25, 2025
| caught_once = True | ||
| break | ||
|
|
||
| if caught_once: |
Collaborator
There was a problem hiding this comment.
If it was true we would already break no?
Contributor
Author
There was a problem hiding this comment.
the first break goes out of the while loop and the second one goes out of the for loop, I agree its a bit confusing so I changed it to look cleaner.
Nir-Az
reviewed
Aug 25, 2025
Nir-Az
approved these changes
Aug 26, 2025
Nir-Az
approved these changes
Aug 26, 2025
Collaborator
|
Added nightly context as there is a low probability to break this API, no need to stale the gating for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-1285]