Support jp7.0 - #14276
Merged
Merged
Conversation
Nir-Az
reviewed
Sep 8, 2025
| echo -e "\e[32mPrepare workspace for kernel build\e[0m" | ||
|
|
||
| if [ "6.0" = "$PATCHES_REV" ]; then | ||
| if [[ ! "6.0" > "$PATCHES_REV" ]]; then |
Collaborator
There was a problem hiding this comment.
Quite complicated condition no?
Why not explicit
if [[ "$PATCHES_REV" >= "6.0" ]]; then
Nir-Az
reviewed
Sep 8, 2025
| patch -p1 < ${sdk_dir}/scripts/realsense-camera-formats-jammy-master.patch | ||
| patch -p1 < ${sdk_dir}/scripts/realsense-metadata-jammy-master.patch | ||
| patch -p1 < ${sdk_dir}/scripts/realsense-powerlinefrequency-control-fix-jammy.patch | ||
| if [[ ! "6.0" > "$PATCHES_REV" ]]; then |
Collaborator
There was a problem hiding this comment.
I see it's all over, matter of style but it takes longer to understand the condition, I prefer the simpler way but since it's not a BUG, your call
ymodlin
self-requested a review
September 8, 2025 11:12
Nir-Az
reviewed
Sep 8, 2025
| name += '.exe' | ||
| import sys | ||
| for p in sys.path: | ||
| paths = os.environ.get('PATH') |
Collaborator
There was a problem hiding this comment.
Please undo as it failed the tests
This reverts commit b28da73.
Nir-Az
approved these changes
Sep 9, 2025
Nir-Az
added a commit
that referenced
this pull request
Sep 14, 2025
Nir-Az
added a commit
that referenced
this pull request
Sep 14, 2025
…a2B - support for JP7.0 and fixed version comparison issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.