Advanced controls over DDS - #14313
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds advanced mode support for DDS devices by refactoring the ds_advanced_mode_base class to support initialization after construction and using debug interfaces instead of requiring hardware monitors.
Key changes include:
- Refactoring
ds_advanced_mode_baseto support deferred initialization throughinitialize_advanced_mode() - Moving
d400_depth_sensorandd500_depth_sensorclass definitions from implementation to header files - Adding advanced mode support to DDS device proxy
- Converting many member initialization constructors to use the new initialization pattern
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| unit-tests/dds/test-librs-options.py | Commented out test case for serialized device functionality |
| third-party/realdds/src/dds-device.cpp | Made methods const to support advanced mode integration |
| third-party/realdds/include/realdds/dds-device.h | Updated method signatures to const and made impl mutable |
| src/types.h | Removed res_type enum and helper function |
| src/sensor.h | Made register_on_open virtual and added override in processing_sensor |
| src/ds/d500/d500-factory.cpp | Updated constructors to use new initialization pattern |
| src/ds/d500/d500-device.h | Moved d500_depth_sensor class definition from .cpp to header |
| src/ds/d500/d500-device.cpp | Moved class definition to header and converted methods to non-inline |
| src/ds/d400/d400-mipi-device.h | Updated constructor signature |
| src/ds/d400/d400-mipi-device.cpp | Updated to use new initialization pattern |
| src/ds/d400/d400-factory.cpp | Updated all device constructors to use new initialization pattern |
| src/ds/d400/d400-device.h | Moved d400_depth_sensor class definition from .cpp to header |
| src/ds/d400/d400-device.cpp | Moved class definition to header and converted methods to non-inline |
| src/ds/advanced_mode/advanced_mode.cpp | Major refactoring to support deferred initialization and debug interface usage |
| src/dds/rs-dds-device-proxy.h | Added advanced mode support to DDS device proxy |
| src/dds/rs-dds-device-proxy.cpp | Implemented advanced mode initialization for DDS devices |
| src/core/advanced_mode.h | Refactored base class to support deferred initialization |
Comments suppressed due to low confidence (1)
src/ds/advanced_mode/advanced_mode.cpp:1
- The variable
_fw_versionis referenced but is no longer available in this scope since thefirmware_versionparameter was removed from the method signature. This code appears to be moved from a different context and needs to be updated.
// License: Apache 2.0. See LICENSE file in root directory.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Nir-Az
reviewed
Sep 28, 2025
OhadMeir
force-pushed
the
advanced_controls
branch
from
September 28, 2025 12:52
abf5e19 to
0a43ce1
Compare
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
reviewed
Sep 29, 2025
Nir-Az
marked this pull request as ready for review
September 29, 2025 12:18
OhadMeir
force-pushed
the
advanced_controls
branch
from
September 30, 2025 14:38
8b06a1c to
1dddddf
Compare
Nir-Az
reviewed
Oct 8, 2025
| # License: Apache 2.0. See LICENSE file in root directory. | ||
| # Copyright(c) 2025 RealSense, Inc. All Rights Reserved. | ||
|
|
||
| # test:device each(D400*) |
Collaborator
There was a problem hiding this comment.
Please update once the FW supports it
Nir-Az
approved these changes
Oct 8, 2025
OhadMeir
force-pushed
the
advanced_controls
branch
from
October 15, 2025 07:42
e1e1ba8 to
816b48b
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tracked on [RSDEV-3616]
rs-dds-device-proxyextendsds_advanced_mode_base. For thatds_advanced_mode_baseneeded some refactoring.Currently opening as draft PR, as a UT still fails the CI and needs to be updated.