Fix D435i IMU Extrinsics - #3901
Closed
radfordi wants to merge 2 commits into
Closed
Conversation
Previously (the rotational part of) _depth_to_imu was applied to the IMU to get depth coordinates when we should have applied the inverse. In addition the translational part was negated. The aligning of the IMU with the depth camera is separated from the exported-to-user/eeprom-stored extrinsics such that the stored and default extrinsics now are with respect to the depth aligned IMU.
Contributor
Author
|
Should have been again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously (the rotational part of)
_depth_to_imuwas applied to the IMU data to put them in depth coordinates when we should have applied the inverse. In addition the translational part of the extrinsics had the wrong sign.To clean this up, the aligning of the IMU with the depth camera is separated from the exported-to-user/eeprom-stored extrinsics such that the stored and default extrinsics now are with respect to the depth-aligned IMU. This has the effect of completely hiding the coarse aligning of the IMU to depth camera from users.
This is based on the extrinsics graph fix, #3900, without which the extrinsics would still be wrong.
CC @dperox, @dmirota, @schmidtp1.