Get Sensor from frame - #3933
Merged
Merged
Conversation
…, frame::get_sensor(), sensor_from_frame() for C++ interface and Frame::Sensor for C# interface. Add demo usage in rs-data-collect and cs-tutorial-2-capture.
Contributor
@doronhi - I think you either forgot to |
ev-mp
suggested changes
May 12, 2019
| for (const auto& elem : data_collection) | ||
| { | ||
| csv << "\n\nStream Type,Index,F#,HW Timestamp (ms),Host Timestamp(ms)" | ||
| csv << "\n\nStream Type,Index,F#,HW Timestamp (ms),Host Timestamp(ms), SerialNumber" |
Contributor
There was a problem hiding this comment.
The SerialNumber attribute to be moved into the header (Lines 121-123 : csv << get_profile_description(elem);)
add unit-test "get_sensor_from_frame"
ev-mp
suggested changes
May 16, 2019
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
I asked for some changes to cover certain corner cases.
Also - pls check with SR300 and T265 live
| { | ||
| // Require at least one device to be plugged in | ||
| rs2::context ctx; | ||
| if (make_context(SECTION_FROM_TEST_NAME, &ctx, "2.13.0")) |
Contributor
There was a problem hiding this comment.
Fix the minimal required version to be 2.22.0
| for (auto i = 0; i < 5; i++) | ||
| { | ||
| rs2::frameset data = pipe.wait_for_frames(); // Wait for next set of frames from the camera | ||
| auto frame = data.get_color_frame(); |
Contributor
There was a problem hiding this comment.
This will fail for sensors w/o color stream. Replace by iterating over all the received frames and making sure all refer to the same S.N
| auto frame = data.get_color_frame(); | ||
| std::string frame_serail_no = sensor_from_frame(frame)->get_info(RS2_CAMERA_INFO_SERIAL_NUMBER); | ||
| REQUIRE(dev_serial_no == frame_serail_no); | ||
| } |
Contributor
There was a problem hiding this comment.
Put a TODO placeholder to check some actual sensor's attributes - > e.g comparing the profile
ev-mp
reviewed
May 16, 2019
| { | ||
| rs2::frameset data = pipe.wait_for_frames(); // Wait for next set of frames from the camera | ||
| auto frame = data.get_color_frame(); | ||
| std::string frame_serail_no = sensor_from_frame(frame)->get_info(RS2_CAMERA_INFO_SERIAL_NUMBER); |
ev-mp
approved these changes
May 16, 2019
Change-Id: Id44b561a8b519dfa207c21824de97eb713bad3af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change interface: add function rs2_get_frame_sensor() for C interface, frame::get_sensor(), sensor_from_frame() for C++ interface and Frame::Sensor for C# interface.
This is used for obtaining the handle of the frame's sensor.
Add demo usage in rs-data-collect and cs-tutorial-2-capture.
Tracked on: DSO-12656