Skip to content

Sensor refactoring - #5111

Merged
dorodnic merged 34 commits into
realsenseai:developmentfrom
arilowen:sensor-refactoring
Nov 15, 2019
Merged

Sensor refactoring#5111
dorodnic merged 34 commits into
realsenseai:developmentfrom
arilowen:sensor-refactoring

Conversation

@arilowen

Copy link
Copy Markdown
Contributor

Sensor refactoring

DSO-13626

  • Add Synthetic Sensor class.
  • Replace unpackers with processing blocks.
  • Add composite processing blocks.

alowenst01 and others added 30 commits October 23, 2019 14:17
Sensor refactoring

- Add Synthetic Sensor class.
- Replace unpackers with processing blocks.
- Add composite processing blocks.
- Move the raw source profiles modification from synthetic_sensor::open() method into
  the derived ::init_stream_profile method
- remove tabs from a few files
- Remove playback's probe and commit profile order restrictions.

@dorodnic dorodnic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Final touches :)

Comment thread include/librealsense2/h/rs_frame.h
Comment thread include/librealsense2/h/rs_sensor.h
Comment thread src/CMakeLists.txt
Comment thread src/context.cpp
Comment thread src/context.cpp Outdated
Comment thread src/proc/CMakeLists.txt Outdated
Comment thread src/sensor.cpp Outdated
Comment thread src/sensor.cpp Outdated
Comment thread src/sensor.cpp
<< ",SystemTime," << std::fixed << system_time
<<" ,diff_ts[Sys-BE],"<< system_time- f.backend_time
<< " ,diff_ts[Sys-BE]," << system_time - f.backend_time
<< ",TS," << std::fixed << timestamp << ",TS_Domain," << rs2_timestamp_domain_to_string(timestamp_domain)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test new generated logs with RsView utility

Comment thread src/sensor.cpp Outdated
- Add new formats to wrappers.
- Remove redundant resolution data from motion frame allocation.
- Restore image-avx.
@dorodnic
dorodnic merged commit 8f01035 into realsenseai:development Nov 15, 2019
@arilowen
arilowen deleted the sensor-refactoring branch December 3, 2019 13:20
Comment thread src/sensor.cpp
{
return {
new internal_frame_callback<T>(callback),
[](rs2_frame_callback* p) { /*p->release(); */}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to why the release is commented out?
It is causing memory leaks. #6337 . #6375 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants