fix SR300 enumeration on linux - #5278
Merged
Merged
Conversation
- add missing yuyv fourcc
ev-mp
reviewed
Nov 20, 2019
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Two non-functional remarks, and it will do
| case RS2_FORMAT_Y8: return 8; | ||
| case RS2_FORMAT_Y16: return 16; | ||
| case RS2_FORMAT_RAW10: return 10; | ||
| case RS2_FORMAT_RAW10: return 16; |
Contributor
There was a problem hiding this comment.
Put a comment for maintainers
| std::stringstream port_path; | ||
| auto port_count = libusb_get_port_numbers(usb_device, usb_ports, max_usb_depth); | ||
| auto usb_dev = std::to_string(libusb_get_device_address(usb_device)); | ||
| auto speed = libusb_get_device_speed(usb_device); |
arilowen
approved these changes
Nov 20, 2019
arilowen
left a comment
Contributor
There was a problem hiding this comment.
Great job on finding and resolving these bugs.
Consider removing the redundant support for YUYV from DS5 cameras.
| { | ||
| std::map<uint32_t, rs2_format> ds5_color_fourcc_to_rs2_format = { | ||
| {rs_fourcc('Y','U','Y','2'), RS2_FORMAT_YUYV}, | ||
| {rs_fourcc('Y','U','Y','V'), RS2_FORMAT_YUYV}, |
Contributor
There was a problem hiding this comment.
I think that ds5 does not support YUYV fourcc format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSO-13973
#5230, #5233, #5219