Software Device update - #5333
Merged
Merged
Conversation
Contributor
|
Continuing and based on #4269 |
Contributor
Author
|
Merged in @callendorph's code. |
…ensor notifications
The API methods for rs2_software_sensor_add_*_stream can return an error in various cases. In the old implementation, the returned error code was not checked before sending the result to the `stream_profile` constructor. This was causing the originating error to get swallowed and made debugging the actual problem harder. This fixes this method so that the first error is reported and not subsequent errors.
This adds a new private method for software_sensor for searching for profiles by UID. This also makes this code more readable.
Issue realsenseai#4197 This adds the ability for the user with access to the `software_device` and `software_sensor` classes to configure and set the `camera_info` parameters. This allows for serial number, name, etc. to be written and configured.
UInlike @callendorph's implementation, it must be specified when you first register the stream_profile
Contributor
Author
|
Force pushed to rebase on development. |
lramati
marked this pull request as ready for review
January 15, 2020 17:15
added 4 commits
January 16, 2020 17:00
Contributor
|
Ping @ev-mp |
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
ev-mp
reviewed
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW Device infrastructure enhance
Fix python wrapper FW update callback
Tracked on: DSO-14348