Update tinyfiledialog to v3.4.1 and set map extension - #5370
Merged
Conversation
radfordi
approved these changes
Dec 4, 2019
Contributor
|
The map is still saved without any extension if no extension is provided. If this is by design, I'm fine with it. More importantly: If I try ti re-import, there is NO file selectable, except those with the .map extension. This is not that good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of tinyfiledialog we have doesn't allow by extension file selection on macOS (see #5245 and #5196). Even the newest version doesn't seem to allow
*.*selection, so this PR introduces the.mapextension of T265 localization maps