Augment "Add Source" button with the number available - #5689
Conversation
| ImGui::SetNextWindowPos({ 0, viewer_model.panel_y }); | ||
|
|
||
| std::string add_source_button_text = to_string() << " " << textual_icons::plus_circle << " Add Source\t\t\t\t\t\t\t\t\t\t\t"; | ||
| std::string add_source_button_text = to_string() << " " << textual_icons::plus_circle << " Add Source (" << (device_names.size() - device_models->size()) << " available)\t\t\t\t\t\t\t\t\t\t\t"; |
There was a problem hiding this comment.
That is a very nice addition for user experience.
To make an impact I'll look if and how it is possible to convert it into a badge with a notification to make it less verbose and avoid Add Source (0 available) message
There was a problem hiding this comment.
I suggest merging this now, and then changing the text to an icon in a second PR. I, just this minute, had another person claim that we don't support multiple T265's when we do, but they couldn't tell because of the reasons outlined above.
There was a problem hiding this comment.
Hi @radfordi - Thanks a lot for your PR.
It needs to be rebased to our latest development branch - easiest way is to make a new branch starting from our development branch and change the line again there.
Can you do that please?
|
Can one of the admins verify this patch? |
When starting the viewer with two or more devices available, only one is shown. This is disconcerting when you have two devices plugged in. The user might then unplug the device which doesn't show up in the viewer and re-plug it in. This leads to the device showing up as expected, but can lead said user to thinking that the system is flaky and doesn't always detect the second device, when really we have detected it. We have just hid it in the "Add Source" pull down. Showing the number of devices in the button text might help ameliorate these feelings of flakiness.