Skip to content

#4297 Multicamera IMU data mix up - #5698

Merged
ev-mp merged 3 commits into
realsenseai:developmentfrom
maloel:hid
Feb 3, 2020
Merged

ev-mp merged 3 commits into
realsenseai:developmentfrom
maloel:hid

Conversation

@maloel

@maloel maloel commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

HID devices now use the unique-ID assigned to their parent node (which is the USB node), letting them be properly associated with the proper composite device.

Multiple HID cameras should be identified correctly.
Addresses #4297
Tracked on: DSO-13711

@maloel
maloel requested a review from dorodnic January 23, 2020 09:41

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic note - some MF/HID-allocated resources in Windows API must be explicitly released to prevent memleaks. Specifically things like BSTR and PROPVARIANT objects (PropVariantClear(&var))
Please run the routine in loop to verify this

Put Tracked on :DSO- num to the header

Comment thread src/context.cpp
Comment thread src/win/win-helpers.cpp
Comment thread src/win/win-helpers.cpp
Comment thread src/win/win-helpers.cpp
Comment thread src/win/win-helpers.h Outdated
* realsenseai#4297 Multicamera IMU data mix up
* Added Windows helper class surrounding Configuration Management nodes
* HID devices now use the unique-ID assigned to their parent node (which is the USB node)

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit 88b3128 into realsenseai:development Feb 3, 2020
@maloel
maloel deleted the hid branch February 13, 2020 12:10
icarpis pushed a commit to icarpis/librealsense that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants