rs-enumerate-devices and libusb handling fixes by ev-mp · Pull Request #5716 · realsenseai/librealsense

ev-mp · 2020-01-26T15:59:36Z

rs-enumerate-devices enhancements and fixes:

Make the tool more robust to device create failure. Reproduced by running w/o udev-rules applied.
Revert -s option to invoke a one-line description per device.
Add -S to provide the device node data (used to be -s)
Update documentation

libusb fix:

Check return value on device open to prevent null de-referencing and segfault. Also applicable to T265 boot.

Addresses #5423

Tracked on: DSO-14190

… Also applies to T265 boot. Make rs-enumerate-devices robust to device create failure. Reproduced by running rs-enumerate-devices w/o udev-rules applied

- Handle exception in case device creation fails. - Introduce `-S` option to present device node info that was previously invoked by `-s` option. - Revert `-s` to a one-line device description

maloel reviewed Jan 29, 2020

View reviewed changes

Comment thread tools/enumerate-devices/rs-enumerate-devices.cpp Outdated

maloel self-assigned this Jan 29, 2020

Evgeni Raikhel added 3 commits February 2, 2020 13:09

Check libusb return value to prevent null dereferencing and segfault.…

0f9d322

… Also applies to T265 boot. Make rs-enumerate-devices robust to device create failure. Reproduced by running rs-enumerate-devices w/o udev-rules applied

rs-enumerate-behavior fixes and enhancements:

81dfccf

- Handle exception in case device creation fails. - Introduce `-S` option to present device node info that was previously invoked by `-s` option. - Revert `-s` to a one-line device description

rs-enumerate-devices doc. update

a10b64d

ev-mp force-pushed the device_ctor_failure branch from 9dc74af to a10b64d Compare February 2, 2020 13:31

ev-mp changed the title ~~Infrastructure fixes and enhancements~~ rs-enumerate-devices fixes and enhancements Feb 2, 2020

ev-mp changed the title ~~rs-enumerate-devices fixes and enhancements~~ rs-enumerate-devices and libusb handling fixes Feb 3, 2020