Added visual presets for L500 - #5741
Merged
Merged
Conversation
aangerma
force-pushed
the
l500_controls
branch
2 times, most recently
from
January 30, 2020 09:48
50bc552 to
bc277fe
Compare
ev-mp
reviewed
Jan 30, 2020
ev-mp
reviewed
Jan 30, 2020
| rs2_set_amp_factor | ||
| rs2_rs400_visual_preset_to_string | ||
| rs2_l500_visual_preset_to_string | ||
| rs2_sensor_mode_to_string |
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 2, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 3, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
maloel
reviewed
Feb 4, 2020
# Conflicts: # include/librealsense2/h/rs_types.h
aangerma
force-pushed
the
l500_controls
branch
from
February 4, 2020 14:14
4f8a534 to
b5d8e69
Compare
# Conflicts: # common/on-chip-calib.cpp # include/librealsense2/h/rs_option.h # src/l500/l500-private.h # src/types.cpp
aangerma
force-pushed
the
l500_controls
branch
from
February 6, 2020 11:35
7f98c85 to
82fa70e
Compare
maloel
reviewed
Feb 6, 2020
| if (std::find(advanced_controls.begin(), advanced_controls.end(), opt) != advanced_controls.end()) | ||
| move_to_custom (); | ||
| else | ||
| throw wrong_api_call_sequence_exception(to_string() << "on_set_option support advanced controlls only "<< opt<<" injected"); |
ev-mp
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for new options in L515:
confidence,
post_processing_sharpness ,
pre_processing_sharpness ,
noise_filtering ,
avalanche_photo_diode
laser_gain,
min_distance ,
invalidation_bypass,
ambient_light
Added visual presets for L500:
RS2_L500_VISUAL_PRESET_NO_AMBIENT,
RS2_L500_VISUAL_PRESET_LOW_AMBIENT,
RS2_L500_VISUAL_PRESET_MAX_RANGE,
RS2_L500_VISUAL_PRESET_SHORT_RANGE
and added support on save and load json for these options.
Tracked on: RS5-6455