Android streamer start time increase fix - #5792
Merged
ev-mp merged 9 commits intoFeb 6, 2020
Merged
Conversation
maloel
reviewed
Feb 5, 2020
| return inst; | ||
| } | ||
|
|
||
| std::recursive_mutex m; |
Contributor
There was a problem hiding this comment.
Hide behind lock() and unlock()
maloel
reviewed
Feb 5, 2020
| @@ -21,8 +21,14 @@ public List<StreamProfile> getStreamProfiles(){ | |||
| public <T extends Sensor> T as(Extension extension) { | |||
| switch (extension){ | |||
Contributor
There was a problem hiding this comment.
Assumes that the sensor is extendable -- need to catch and throw an error if not extendable...
remibettan
force-pushed
the
android-streamer-start-time-increase-fix
branch
from
February 6, 2020 07:28
0691388 to
094d619
Compare
remibettan
force-pushed
the
android-streamer-start-time-increase-fix
branch
from
February 6, 2020 07:59
094d619 to
b44a29d
Compare
ev-mp
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoclosable try added for getting device into Updateable - bug was only in the Android wrapper.
Tracked on: DS5U-4538, DSO-14302