Skip to content

multi-camera connection - #5800

Merged
ev-mp merged 12 commits into
realsenseai:developmentfrom
doronhi:multicam
Jul 21, 2020
Merged

multi-camera connection#5800
ev-mp merged 12 commits into
realsenseai:developmentfrom
doronhi:multicam

Conversation

@doronhi

@doronhi doronhi commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Fix a bug concerning connection to multiple cameras by several threads or processes.
Tracked on: DSO-13745

@mhkabir

mhkabir commented Feb 10, 2020

Copy link
Copy Markdown

Hey guys, any timeline on getting this in? This is a long-standing bug for multi-camera users.

@mhkabir

mhkabir commented Feb 12, 2020

Copy link
Copy Markdown

@dorodnic @doronhi

@dorodnic

Copy link
Copy Markdown
Contributor

Hi @mhkabir
We are testing this solution and will merge it soon.

@mhkabir

mhkabir commented Mar 4, 2020

Copy link
Copy Markdown

Any updates?

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the rs-multicam changes

Comment thread examples/multicam/rs-multicam.cpp Outdated
{
// Create a simple OpenGL window for rendering:
window app(1280, 960, "CPP Multi-Camera Example");
bool display(true);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example's refactoring to be handled separately from the fix

@mhkabir

mhkabir commented Mar 17, 2020

Copy link
Copy Markdown

Bump @ev-mp @doronhi @dorodnic

@tispratik

Copy link
Copy Markdown

Bump. We're facing same issue. Long discussion here #5828

@mhkabir

mhkabir commented Apr 4, 2020

Copy link
Copy Markdown

@doronhi @dorodnic @ev-mp @RealSense-Customer-Engineering Is there a timeline for validating this and getting it in?

Comment thread src/linux/backend-v4l2.cpp Outdated
if (_dev_mutex_cnt[_device_path] < 0)
{
_dev_mutex_cnt[_device_path] = 0;
throw linux_backend_exception("HOW DID WE GET HERE??");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make constructive comment

throw linux_backend_exception(to_string() << "Acquire failed");
auto ret = lockf(_fildes, F_LOCK, 0);
if (0 != ret)
throw linux_backend_exception(to_string() << "Acquire failed");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will _dev_mutex[_device_path].unlock(); be called in case of exception?

@doronhi
doronhi changed the base branch from development to ac July 6, 2020 08:08
@ev-mp
ev-mp changed the base branch from ac to development July 20, 2020 09:00

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit b38163d into realsenseai:development Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants