Small fixes - #5977
Merged
Merged
Conversation
Fetch and update each sensor individually instead of once per device
maloel
reviewed
Mar 6, 2020
|
|
||
| auto depth_ep = std::make_shared<ds5_depth_sensor>(this, raw_depth_ep); | ||
|
|
||
| depth_ep->register_info(RS2_CAMERA_INFO_PHYSICAL_PORT, filter_by_mi(all_device_infos, 0).front().device_path); |
Contributor
There was a problem hiding this comment.
filter_by_mi() was already called in line 545. Maybe you can keep result in var then can reuse... I couldn't find any function of uvc_device to get the device path, but maybe there is and then you can use depth_devices?
maloel
reviewed
Mar 6, 2020
| depth_ep->get_option(RS2_OPTION_GLOBAL_TIME_ENABLED).set(0); | ||
|
|
||
|
|
||
| depth_ep->register_info(RS2_CAMERA_INFO_PHYSICAL_PORT, filter_by_mi(all_device_infos, 0).front().device_path); |
maloel
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rs-enumerate-devices