Added depth_frame::get_units() - #5996
Merged
Merged
Conversation
maloel
commented
Mar 9, 2020
Contributor
- With C#, Python, Android wrappers
* Returns depth, in meters, per 1 unit stored in the frame data * Function already existed inside the sensor API (depth_sensor::get_depth_scale) & at the bottom of the hourglass (depth_frame::get_unit), but wasn't exposed at the top * Added a corresponding C fn (rs2_depth_frame_get_units) * Updated CV examples' depth_frame_to_meters() so it no longer needs to get the pipeline
ev-mp
reviewed
Mar 9, 2020
| // Convert RealSense frame to OpenCV matrix: | ||
| auto color_mat = frame_to_mat(color_frame); | ||
| auto depth_mat = depth_frame_to_meters(pipe, depth_frame); | ||
| auto depth_mat = depth_frame_to_meters(depth_frame); |
Contributor
There was a problem hiding this comment.
Is this the only place where that function is called?
ev-mp
approved these changes
Mar 9, 2020
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Do you have DSO number for tracking ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.