Added HW sync enable control for L515 - #6000
Merged
Merged
Conversation
ev-mp
reviewed
Mar 9, 2020
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
I marked a few minor for changes/review
| virtual void set( float value ) override; | ||
| virtual const char* get_description() const override | ||
| { | ||
| return "When enabled (disabled on startup), interrupts are handled according to GPIO10 level; shuts off the fall detect mechanism"; |
Contributor
There was a problem hiding this comment.
Maybe we need to rephrase for the user's experience perspective
Contributor
Author
There was a problem hiding this comment.
Even the other option (RS2_OPTION_INTER_CAM_SYNC_MODE) test "Inter-camera synchronization mode: 0:Default, 1:Master, 2:Slave" is not useful.
"Enable multi-camera hardware synchronization mode; not compatible with free-fall detection"?
ev-mp
reviewed
Mar 11, 2020
ev-mp
reviewed
Mar 17, 2020
ev-mp
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: RS5-6978