Skip to content

Merge of 'rc2' branch - #6487

Merged
ev-mp merged 17 commits into
realsenseai:developmentfrom
maloel:rc2_merge
Jun 1, 2020
Merged

Merge of 'rc2' branch#6487
ev-mp merged 17 commits into
realsenseai:developmentfrom
maloel:rc2_merge

Conversation

@maloel

@maloel maloel commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just check the comment - I'm not sure it should be removed

Comment thread readme.md
@@ -2,10 +2,6 @@

-----------------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be left in place?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorodnic Can you comment? Should this stay in, or be removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?

Comment thread readme.md
@@ -2,10 +2,6 @@

-----------------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?

@ev-mp

ev-mp commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

@maloel , please update the PR content and RS5-xxxx references.
No further changes are required.

@ev-mp
ev-mp merged commit 2a79d31 into realsenseai:development Jun 1, 2020
@maloel
maloel deleted the rc2_merge branch March 25, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants