hexify helper method name in test changed to char2hex - #6629
Merged
ev-mp merged 1 commit intoJun 18, 2020
Conversation
ev-mp
approved these changes
Jun 18, 2020
ev-mp
suggested changes
Jun 18, 2020
remibettan
force-pushed
the
fix-linkage-hexify-method
branch
from
June 18, 2020 08:08
96f1838 to
721a2a1
Compare
ev-mp
approved these changes
Jun 18, 2020
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
For now types.h. will remain private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same name of helper function in global namespace lead to failure in linkage.