Fix the value of RS2_OPTION_FILTER_MAGNITUDE option in Unity wrapper - #6644
Merged
Conversation
mengyui
force-pushed
the
unity-pointcloud-fix
branch
from
June 20, 2020 08:48
6bf5096 to
98565e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of RS2_OPTION_FILTER_MAGNITUDE defined in Unity wrapper are wrong.
In the wrapper, there are 3 values in PointCloud processing block.
https://github.com/IntelRealSense/librealsense/blob/v2.35.2/wrappers/unity/Assets/RealSenseSDK2.0/Scripts/ProcessingBlocks/RsPointCloud.cs#L6-L11
But in the core library, there are 2 value for it.
https://github.com/IntelRealSense/librealsense/blob/v2.35.2/src/proc/pointcloud.cpp#L239-L241
Fix #6579 #6647