SW Updates - Fix UI issue + allow use of local DB file - #7294
Merged
maloel merged 1 commit intoSep 13, 2020
Conversation
Nir-Az
commented
Sep 10, 2020
Collaborator
- Overcome im_gui issue that cause an error pop_up closing the updates window. (always force open it unless no need)
- Allow local version's DB file use. (Treat "file://" prefix as local file path)
maloel
reviewed
Sep 10, 2020
| auto server_url = config_file::instance().get(configurations::update::sw_updates_url); | ||
| sw_update::dev_updates_profile updates_profile(dev, server_url); | ||
| std::string server_url = config_file::instance().get(configurations::update::sw_updates_url); | ||
| bool file_is_on_server = true; |
Contributor
There was a problem hiding this comment.
I prefer to name it with the same meaning as the curl flag, file_is_local, but up to you...
Collaborator
Author
There was a problem hiding this comment.
Accepted and changed.
maloel
approved these changes
Sep 10, 2020
Nir-Az
force-pushed
the
SW_update_allow_local_file
branch
from
September 10, 2020 13:16
e58debb to
c65b758
Compare
maloel
approved these changes
Sep 10, 2020
Collaborator
Author
|
Tracked on [RS5-8831] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.