Krgb-thermal support - #7297
Merged
Merged
Conversation
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 10, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 11, 2020
maloel
reviewed
Sep 13, 2020
maloel
reviewed
Sep 13, 2020
maloel
reviewed
Sep 13, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
| } | ||
| // The temperature may depend on streaming? | ||
| std::vector<byte> res; | ||
| throw std::runtime_error( "HW monitor is inaccessible - stopping algo" ); |
Contributor
Author
There was a problem hiding this comment.
we said that I will lock the hwm to protect the case that the device will no longer exist.
Contributor
There was a problem hiding this comment.
I still don't understand why you changed the behavior of read_temperature()
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 17, 2020
maloel
reviewed
Sep 24, 2020
maloel
reviewed
Sep 24, 2020
maloel
reviewed
Sep 24, 2020
maloel
reviewed
Sep 24, 2020
maloel
reviewed
Sep 24, 2020
maloel
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading k-thermal table from FW and use it to correct k-rgb according to current humidity temp,
the k-rgb that written to FW is without the thermal correct ,but user will get the corrected one.