Skip to content

returning nullptr instead of throwing exception - #7542

Merged
ev-mp merged 2 commits into
realsenseai:developmentfrom
remibettan:get_option_handler-fix
Oct 13, 2020
Merged

returning nullptr instead of throwing exception#7542
ev-mp merged 2 commits into
realsenseai:developmentfrom
remibettan:get_option_handler-fix

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

returning nullptr instead of throwing exception

Comment thread src/core/options.h

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need to be verified with FW 5.12.7.100

@remibettan

Copy link
Copy Markdown
Contributor Author

Checked with FW 5.12.7.100

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit 2ef61da into realsenseai:development Oct 13, 2020
@remibettan
remibettan deleted the get_option_handler-fix branch March 15, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants