Skip to content

checking lrs version, options supported and metadata available - #7543

Merged
ev-mp merged 2 commits into
realsenseai:developmentfrom
remibettan:hdr-live-tests-corrected
Oct 27, 2020
Merged

checking lrs version, options supported and metadata available#7543
ev-mp merged 2 commits into
realsenseai:developmentfrom
remibettan:hdr-live-tests-corrected

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

librealsense version, fw supporting hdr options and metadata params supported checked.
This PR should be merged after PR 7542 is merged.

Comment thread unit-tests/unit-tests-hdr.cpp
Comment thread unit-tests/unit-tests-hdr.cpp Outdated
int iterations_for_preparation = 6;
while (++iteration < 50) // Application still alive?
if (depth_sensor && depth_sensor.supports(RS2_OPTION_SEQUENCE_ID) &&
depth_sensor.supports(RS2_OPTION_HDR_ENABLED))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same condition here and below

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean same comment as above?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread unit-tests/unit-tests-hdr.cpp
Comment thread unit-tests/unit-tests-hdr.cpp Outdated
Comment thread unit-tests/unit-tests-hdr.cpp Outdated
Comment thread unit-tests/unit-tests-hdr.cpp Outdated
Comment thread unit-tests/unit-tests-hdr.cpp Outdated

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ev-mp
ev-mp merged commit b58a360 into realsenseai:development Oct 27, 2020
@remibettan
remibettan deleted the hdr-live-tests-corrected branch March 15, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants