Fw logger tool adding sleep - #7619
Merged
ev-mp merged 17 commits intoNov 1, 2020
Merged
Conversation
ev-mp
reviewed
Oct 21, 2020
removing parsed data
ev-mp
reviewed
Oct 26, 2020
| { | ||
| VALIDATE_NOT_NULL(dev); | ||
|
|
||
| auto fw_loggerable = VALIDATE_INTERFACE(dev->device, librealsense::firmware_logger_extensions); |
Contributor
There was a problem hiding this comment.
fw_loggerable -> fw_logger
Return unsigned
Contributor
Author
There was a problem hiding this comment.
done - changed in multiple methods in this file
ev-mp
reviewed
Oct 28, 2020
| { | ||
| VALIDATE_NOT_NULL(dev); | ||
|
|
||
| auto fw_loggerable = VALIDATE_INTERFACE(dev->device, librealsense::firmware_logger_extensions); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a sleep between each fw log polling.
Default value is hardcoded in the tool's code.
This can be also input by the user using -s <sleep_in_ms>
Triggered by Jira DSO-15939