encapsulate linux test - #7751
Merged
Merged
Conversation
ev-mp
reviewed
Dec 10, 2020
| @@ -1,3 +1,5 @@ | |||
| #ifdef __linux__ | |||
Contributor
There was a problem hiding this comment.
It should be probably handled on CMake level
ev-mp
reviewed
Feb 4, 2021
| ) | ||
|
|
||
| if(UNIX) | ||
| list(APPEND INTERNAL_TESTS_SOURCES internal-tests-linux.cpp) |
ev-mp
reviewed
Feb 4, 2021
| ../approx.h | ||
| ) | ||
|
|
||
| if(UNIX) |
Contributor
There was a problem hiding this comment.
UNIX includes Android as well. If it doesn't apply then it should be unix && !android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encapsulate the content of internal-tests-linux.cpp with #ifdef linux .