convert frame to frameset in post processing filters - #7759
Merged
Conversation
ev-mp
approved these changes
Nov 15, 2020
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Please mention the issue and its fix in PR's description
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track on: DSO-15250
Allocating a frame to frameset in post_processing_filter c'tor returns NULL that passed to process_frameset(..)
Because we want to work also with frames in post processing filters and not only framesets, the allocation is removed and the function signature changed to process_frame(..), its input and output changed from frameset to frame, and it solved the issue !
Addresses #7584