pybind linux - Fix missing debug symbols in RelWithDebug mode - #7812
Merged
maloel merged 1 commit intoNov 25, 2020
Merged
Conversation
maloel
approved these changes
Nov 19, 2020
maloel
left a comment
Contributor
There was a problem hiding this comment.
Let's talk about it before we merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output binary .so file of building pyrealsense2 on Linux and on configuration RelWithDebInfo does not contain symbols.
This is cause due to a known issue at pybind11 version 2.2.1 that is used in librealsense SDK.
The issue was fixed at PR1892 at pybind11 repo.
This PR implement the same fix.
Linux python 2.7 wheel size before this changes is : ~10 [MB]
Linux python 2.7 wheel size after this changes is : ~70 [MB]