Added rs2_get_target_size_on_frame and updated python wrapper to use it. - #7997
Merged
Conversation
ev-mp
reviewed
Dec 22, 2020
Contributor
Author
|
Pushed code in with the changes. |
2. FIxed node.js build error.
ev-mp
reviewed
Dec 28, 2020
ev-mp
reviewed
Mar 24, 2021
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Note the conflict with the dev branch - need to be resolved prior to merge
# Conflicts: # common/on-chip-calib.cpp
Contributor
Author
Merged to the latest dev branch code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API rs2_get_target_size_on_frame is created and exposed in the Python wrapper .