Skip to content

Remove default preset - #8002

Merged
maloel merged 40 commits into
realsenseai:developmentfrom
aangerma:RS5-8999
Jan 31, 2021
Merged

Remove default preset#8002
maloel merged 40 commits into
realsenseai:developmentfrom
aangerma:RS5-8999

Conversation

@aangerma

@aangerma aangerma commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

This PR includes:

  1. Remove default preset
  • on LRS start up we calculate if we are in one of the presets
    and if not we are on custom
  • when loading old Json file if the preset is default the preset will be custom
  • if user try to set preset default he will get an error.
  1. Reading of defaults values
  • on new fw versions( >1.5.3.0) is by get_default command
  • on old fw versions its stay as it was - set_current -1 and than get_current gives the defaults values
  1. update defaults values of hw options on the following cases
  • on startup
  • when changing resolution
  • when changing gain
  1. Flow of set preset
  • set gain according to preset
  • read the default values
  • set default values to currents
  • set laser according to preset

(RS5-8999)

Comment thread common/model-views.cpp Outdated
Comment thread include/librealsense2/h/rs_option.h
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/option.h Outdated
Comment thread unit-tests/func/func-common.h Outdated
Comment thread unit-tests/func/presets/test-calc-preset-change-controls.cpp Outdated
Comment thread unit-tests/func/presets/test-calc-preset-change-controls.cpp Outdated
Comment thread unit-tests/func/presets/test-calc-preset-change-controls.cpp Outdated
Comment thread unit-tests/func/presets/test-calc-preset-change-controls.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.cpp Outdated
Comment thread src/l500/l500-options.h Outdated
Comment thread src/l500/l500-options.h Outdated
Comment thread src/l500/l500-options.h Outdated
Comment thread src/l500/l500-options.cpp Outdated
@maloel
maloel merged commit cc2de7f into realsenseai:development Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants