FW update exception fix - #8018
Merged
Merged
Conversation
ev-mp
suggested changes
Dec 22, 2020
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
SR300 DFU handling should be adjusted as wel, similar to D400 and L515
| _hw_monitor->get_gvd(gvd_buff.size(), gvd_buff.data(), ds::GVD); | ||
| this_thread::sleep_for(milliseconds(50)); | ||
| } | ||
| throw std::runtime_error("Device still connected!"); |
Contributor
There was a problem hiding this comment.
Reword with "Device failed to switch to DFU within the predefined time"
| cmd.param1 = 1; | ||
| _hw_monitor->send(cmd); | ||
| std::vector<uint8_t> gvd_buff(HW_MONITOR_BUFFER_SIZE); | ||
| for (auto i = 0; i < 10; i++) |
Contributor
There was a problem hiding this comment.
Increase iterations count to cover 1000msec
Comment in code as to how the mechanism is expected to work
| // Stop all data streaming/exchange pipes with HW | ||
| stop_activity(); | ||
| using namespace std; | ||
| using namespace std::chrono; |
Contributor
There was a problem hiding this comment.
In this case use of explicit std::this_thread... std::chrono:millisec(..) is preferred
| cmd.param1 = 1; | ||
| _hw_monitor->send(cmd); | ||
| std::vector<uint8_t> gvd_buff(HW_MONITOR_BUFFER_SIZE); | ||
| for (auto i = 0; i < 25; i++) |
Contributor
There was a problem hiding this comment.
The counter here and for DS5.cpp should probably be synchronized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FW update runs, the device disconnects when it switches to DFU.
Exception is thrown when FW update calls query devices while device still connected (not switch to DFU already).
In this fix, after sending the command of switching device to DFU, I checked when device is disconnected then continue to next step of querying devices.
Tracked on DSO-16069