EasyLogging - add asynchronous handling (Linux) - #8048

Merged

ev-mp merged 17 commits into

realsenseai:developmentfrom

remibettan:el_linux_elpp_messages

Jan 26, 2021

remibettan commented Dec 22, 2020 •

edited by ev-mp

Loading

Contributor

Tracked on: DSO-16295

remibettan force-pushed the el_linux_elpp_messages branch 2 times, most recently from b5835d4 to f24da47 Compare

December 24, 2020 15:23

remibettan marked this pull request as ready for review

December 24, 2020 15:24

remibettan requested a review from ev-mp

December 24, 2020 15:25

ev-mp suggested changes

View reviewed changes

ev-mp left a comment

Contributor

Add unit-tests as discussed

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.h Outdated

third-party/easyloggingpp/src/easylogging++.h Outdated

remibettan force-pushed the el_linux_elpp_messages branch from e91cf33 to faad98f Compare

December 28, 2020 12:10

remibettan requested a review from ev-mp

December 29, 2020 13:11

remibettan force-pushed the el_linux_elpp_messages branch 3 times, most recently from 8967923 to 0a83da5 Compare

January 5, 2021 09:07

remibettan force-pushed the el_linux_elpp_messages branch from bb57a4a to 589b5af Compare

January 10, 2021 11:08

ev-mp suggested changes

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.h Outdated

third-party/easyloggingpp/src/easylogging++.h Outdated

third-party/easyloggingpp/src/easylogging++.h Outdated

unit-tests/log/test-multi-thread-logs.cpp

third-party/easyloggingpp/src/easylogging++.cc

unit-tests/log/test-multi-thread-logs.cpp Outdated

remibettan force-pushed the el_linux_elpp_messages branch 9 times, most recently from b6f07dc to 7f1e16d Compare

January 13, 2021 15:37

ev-mp suggested changes

View reviewed changes

ev-mp left a comment

Contributor

Some minor comments and fine-tuning

CMake/global_config.cmake Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

third-party/easyloggingpp/src/easylogging++.cc Outdated

unit-tests/log/test-multi-thread-logs.cpp

unit-tests/log/test-multi-thread-logs.cpp Outdated

unit-tests/log/test-multi-thread-logs.cpp Outdated

unit-tests/log/test-multi-thread-logs.cpp Outdated

unit-tests/log/test-multi-thread-logs.cpp Outdated

remibettan force-pushed the el_linux_elpp_messages branch from df7d51d to 7890c69 Compare

January 14, 2021 12:03

maloel reviewed

View reviewed changes

CMake/global_config.cmake Outdated

maloel reviewed

View reviewed changes

CMake/global_config.cmake Outdated

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp Outdated

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp Outdated

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp Outdated

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp Outdated

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp

maloel reviewed

View reviewed changes

unit-tests/log/test-multi-thread-logs.cpp

remibettan force-pushed the el_linux_elpp_messages branch 2 times, most recently from 2ab8086 to 9d24fd4 Compare

January 14, 2021 15:38

remibettan and others added 16 commits

January 24, 2021 08:42


          enabling async log in linux, , flushAll method adjusted for async log


          easy log methods thread safe fixes

fd5b395


          multi-thread logs test added

32d7260


          async logger for all os, and with logger internal debug messages

6f57a1a


          async log writing to queue not only when logging to file

fb430ff


          double queue added

d5d6b6f


          moving content from write queue to read queue efficiently

738f3f3


          queues changed to deques

90947a6


          avoid configuring logger while handling messages

e6a1373


          adding pragma ifdef async logger

c5613bc


          el async in linux only

c9ab09a


          enabling async logger test according to the cmake flag

74ab160


          code review corrections - renaming removed and comments added

c19300b


          async logger test - target of log action limited to 10 ms instead of …

aef6e13

…50 ms


          async logger test - correctness and performance checkings added

7dd4f90


          lock_guard added in test

357d8f8

remibettan force-pushed the el_linux_elpp_messages branch from e56a9aa to 2ccdfb4 Compare

January 24, 2021 07:53


          easy logging async flag added to cmake flags

1b8d306

remibettan force-pushed the el_linux_elpp_messages branch from 2ccdfb4 to 1b8d306 Compare

January 24, 2021 11:28

ev-mp approved these changes

View reviewed changes

ev-mp left a comment

Contributor

Good job

ev-mp merged commit 92c981f into realsenseai:development

ev-mp changed the title ~~El linux elpp messages~~ EasyLogging - add asynchronous handling (Linux)

remibettan deleted the el_linux_elpp_messages branch

March 15, 2021 06:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet