Skip to content

Add MUR and reflectivity unit tests - #8056

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
Nir-Az:add_mur_and_reflectivity_ut
Mar 3, 2021
Merged

Add MUR and reflectivity unit tests#8056
maloel merged 1 commit into
realsenseai:developmentfrom
Nir-Az:add_mur_and_reflectivity_ut

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Dec 23, 2020

Copy link
Copy Markdown
Collaborator

Tracked on [RS5-9400]

maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-MSS-streaming.cpp
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-MSS-streaming.cpp
maloel
maloel reviewed Jan 4, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-MSS-streaming.cpp Outdated
maloel
maloel reviewed Jan 12, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
maloel
maloel reviewed Jan 12, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
maloel
maloel reviewed Jan 12, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
@Nir-Az
Nir-Az force-pushed the add_mur_and_reflectivity_ut branch from 9f1f632 to dae3827 Compare February 21, 2021 10:26
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-change-preset.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-change-preset.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-change-sensor-mode.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-reading-option-off.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-reading-option-off.cpp
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-require-vga-streaming.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-change-sensor-mode.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-mss-no-streaming.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-not-force-mur-off.cpp Outdated
maloel
maloel reviewed Feb 21, 2021
View reviewed changes

@maloel maloel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK. I want to shorten it. Let's talk...

@Nir-Az
Nir-Az force-pushed the add_mur_and_reflectivity_ut branch 2 times, most recently from 07801df to 57858b3 Compare February 25, 2021 11:39
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-Reading-MUR-option-off.cpp Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-sanity.cpp
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-turn-off-IR-Reflectivity.cpp Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/func-common.h Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp Outdated
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-auto-set-options.cpp
maloel
maloel reviewed Feb 25, 2021
View reviewed changes
Comment thread unit-tests/func/MUR/l500/test-turn-off-IR-Reflectivity.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-bad-conditions.cpp
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-bad-conditions.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-bad-conditions.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-bad-conditions.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-sanity.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/mur/l500/test-sanity.cpp
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-auto-set-options.cpp Outdated
maloel
maloel reviewed Feb 28, 2021
View reviewed changes
Comment thread unit-tests/func/reflectivity/l500/test-sanity.cpp
@Nir-Az
Nir-Az force-pushed the add_mur_and_reflectivity_ut branch from bc4ca6c to 43c3113 Compare March 2, 2021 15:31
@maloel
maloel merged commit 216062f into realsenseai:development Mar 3, 2021
@Nir-Az
Nir-Az deleted the add_mur_and_reflectivity_ut branch April 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maloel maloel maloel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nir-Az @maloel