SKU B5B - #8365
Merged
Merged
Conversation
ev-mp
reviewed
Feb 16, 2021
ev-mp
suggested changes
Feb 20, 2021
remibettan
marked this pull request as ready for review
February 21, 2021 11:30
remibettan
force-pushed
the
SKU_B5B
branch
2 times, most recently
from
March 2, 2021 14:18
e771616 to
695fd28
Compare
ev-mp
suggested changes
Mar 4, 2021
| std::vector<std::shared_ptr<processing_block_model>> const_effects; | ||
|
|
||
| private: | ||
| const float SHORT_RANGE_MIN_DISTANCE; |
Contributor
There was a problem hiding this comment.
- Indentation
- Switch from all Capital to regular
| detected_objects(device_detected_objects) | ||
| detected_objects(device_detected_objects), | ||
| SHORT_RANGE_MIN_DISTANCE(0.05f), | ||
| SHORT_RANGE_MAX_DISTANCE(1.5f) |
Contributor
There was a problem hiding this comment.
Check if it is possible to increase to 2 up to 3 meter and check how it applies to Colorizer and Threshold filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by: DSO-16440