Fix syncer bug causing wrong frame order - #8378

Merged

maloel merged 9 commits into

realsenseai:developmentfrom

aangerma:RS5-10200

Feb 23, 2021

aangerma commented Feb 17, 2021 •

edited by ev-mp

Loading

Contributor

fixed l500 matcher hierarchy (remove timestamp_composite_matcher as root above device-generated matcher)
Added mutex to protect try_dequeue and calling to callback
added log parameter to syncer

Tracked on: RS5-10200


          1. fixed l500 matcher hierarchy

a49d873

2.  Added mutex to protect try_dequeue and calling to callback
3. added log parameter to syncer

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.h Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.h Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/l500/l500-device.cpp Outdated

maloel reviewed

View reviewed changes

src/l500/l500-device.cpp Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel commented Feb 17, 2021

Contributor

Make sure to provide Yehuda a side-drop and run RealCI on both D400 and L500 to make sure we didn't break anything

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel changed the title ~~Fixed bug on syncer (RS5-10200)~~ Fix syncer bug causing wrong frame order (RS5-10200)

ev-mp changed the title ~~Fix syncer bug causing wrong frame order (RS5-10200)~~ Fix syncer bug causing wrong frame order

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

src/sync.cpp Outdated

maloel reviewed

View reviewed changes

maloel left a comment

Contributor

Don't forget to remove the lines in l500_depth::create_matcher


          CR fixes

6d05f45

aangerma force-pushed the RS5-10200 branch from 99ef957 to 6d05f45 Compare

February 18, 2021 17:51


          CR fixes

c832dcf

aangerma force-pushed the RS5-10200 branch from a62f54b to c80b98a Compare

February 18, 2021 18:30


          Fix for Linux

0a3fe1c

aangerma force-pushed the RS5-10200 branch from c80b98a to 0a3fe1c Compare

February 18, 2021 18:37

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.h Outdated

maloel reviewed

View reviewed changes

src/sync.cpp

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated


          CR fixes

2eba69e

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp


          Fixes

bde0e82

maloel approved these changes

View reviewed changes

maloel left a comment

Contributor

We'll wait for the result from RealCI before merging this...

maloel reviewed

View reviewed changes

src/proc/syncer-processing-block.cpp Outdated

aangerma added 2 commits

February 21, 2021 13:23

Fix

85eaf25


          More CR fixes

043ffc9

maloel reviewed

View reviewed changes

src/sync.cpp

+                          s << " " << f->get_stream()->get_unique_id();
+                          s << " " << f->get_frame_number();
+                          s << " " << std::fixed << (double)f->get_frame_timestamp();
+                          s << " ";

maloel Feb 21, 2021

Contributor

What's this for?


          Fixed small bug

0cd6dd3

maloel merged commit 668bf9b into realsenseai:development

maloel mentioned this pull request

Syncer now produces frameset - always #8573

Merged

shivak7 mentioned this pull request

Number of frames in .bag file does not correspond to expected number of frames #8949

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet