Skip to content

Update python package descriptors for python 3.8 + 3.9 - #8405

Merged
maloel merged 3 commits into
realsenseai:developmentfrom
Nir-Az:update_python_package_descriptors
Feb 22, 2021
Merged

Update python package descriptors for python 3.8 + 3.9#8405
maloel merged 3 commits into
realsenseai:developmentfrom
Nir-Az:update_python_package_descriptors

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Feb 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Package classifiers updated to support python 3.8 + 3.9

[DSO-16485]
image

ev-mp
ev-mp reviewed Feb 21, 2021
View reviewed changes

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about dropping support for 3.4 (3.5) ?

@Nir-Az

Nir-Az commented Feb 21, 2021

Copy link
Copy Markdown
Collaborator Author

What about dropping support for 3.4 (3.5) ?

Good catch - I removed this classifiers

@maloel

maloel commented Feb 21, 2021

Copy link
Copy Markdown
Contributor

No other references to Python versions in our code/docs?

@Nir-Az

Nir-Az commented Feb 21, 2021

Copy link
Copy Markdown
Collaborator Author

No other references to Python versions in our code/docs?

Our current description is generic:

Windows users can install the RealSense SDK 2.0 from the release tab to get pre-compiled binaries of the wrapper, for both x86 and x64 architectures. (Both Python 2.7 and Python 3 are supported)

ev-mp
ev-mp reviewed Feb 21, 2021
View reviewed changes

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating https://github.com/IntelRealSense/librealsense/tree/master/wrappers/python#installation as well

@Nir-Az

Nir-Az commented Feb 21, 2021

Copy link
Copy Markdown
Collaborator Author

Consider updating https://github.com/IntelRealSense/librealsense/tree/master/wrappers/python#installation as well

Agreed and updated

@maloel
maloel merged commit 881e0ea into realsenseai:development Feb 22, 2021
@Nir-Az
Nir-Az deleted the update_python_package_descriptors branch April 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@ev-mp ev-mp ev-mp left review comments
@maloel maloel maloel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nir-Az @maloel @ev-mp