Skip to content

Auto Exposure : range value setting limitation - #8519

Merged
ev-mp merged 12 commits into
realsenseai:developmentfrom
nohayassin:dso_16596_fix
Mar 25, 2021
Merged

Auto Exposure : range value setting limitation#8519
ev-mp merged 12 commits into
realsenseai:developmentfrom
nohayassin:dso_16596_fix

Conversation

@nohayassin

Copy link
Copy Markdown
Contributor

When setting Auto Exposure value outside the fixed limit, error will be printed to the log and AE value will remain as previous valid value.
Track on DSO-16596

Comment thread src/ds5/ds5-options.cpp Outdated

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that I marked is getting the range from the MANUAL_EXPOSURE value and doing the same fix for auto_gain_limit

Comment thread src/ds5/ds5-options.cpp Outdated
Comment thread src/ds5/ds5-options.cpp Outdated
Comment thread src/ds5/ds5-options.h
Comment thread unit-tests/internal/internal-tests-extrinsic.cpp Outdated
Comment thread unit-tests/internal/internal-tests-extrinsic.cpp Outdated

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version looks good.
Note the conflict notification with the dev branch - needs to be resolved

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit 0df661a into realsenseai:development Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants