Syncer now produces frameset - always - #8573
Merged
Merged
Conversation
maloel
reviewed
Mar 14, 2021
| _matcher = dev->create_matcher(frame); | ||
| frame_holder f; | ||
| { | ||
| std::lock_guard< std::mutex > lock(_callback_mutex); |
Contributor
There was a problem hiding this comment.
What happened to:
// Another thread has the lock, meaning will get into the following loop and dequeue all
// the frames. So there's nothing for us to do...
std::unique_lock< std::mutex > lock(_callback_mutex, std::try_to_lock);
if (!lock.owns_lock())
return;
maloel
approved these changes
Mar 14, 2021
maloel
added a commit
that referenced
this pull request
Mar 14, 2021
(cherry picked from commit 6e01478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the playback with syncer bug added on #8378 and pipeline with single stream bug:
The old code expected syncer output to always be a frameset.