Skip to content

Adding SR300 derivative into SDK core - #8713

Merged
ev-mp merged 9 commits into
realsenseai:developmentfrom
nohayassin:dso_16719_start
Apr 8, 2021
Merged

Adding SR300 derivative into SDK core#8713
ev-mp merged 9 commits into
realsenseai:developmentfrom
nohayassin:dso_16719_start

Conversation

@nohayassin

Copy link
Copy Markdown
Contributor

The following tools are functioning in SR300-like device :

  • rs-enumerate-devices
  • Realsense-viewer streaming
  • Realsense-viewer controls

Track on: DSO-16719

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Follow the comments

Comment thread common/model-views.cpp Outdated
Comment thread src/ivcam/ivcam-private.cpp Outdated
Comment thread src/ivcam/ivcam-private.h Outdated
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/context.cpp Outdated
Comment thread src/ivcam/sr300.h Outdated
Comment thread src/ivcam/sr300.h Outdated
Comment thread src/ivcam/sr300.h Outdated
Comment thread src/winusb/handle-winusb.h Outdated
Comment thread tools/benchmark/rs-benchmark.cpp Outdated
@ev-mp ev-mp changed the title Adding SR300-like device but without the RGB sensor into the SDK core Adding SR300 derivative into SDK core Apr 4, 2021

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments to review/verify

Comment thread src/ivcam/sr300.cpp
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/ivcam/sr300.h Outdated
Comment thread tools/benchmark/rs-benchmark.cpp Outdated
Comment thread tools/depth-quality/depth-quality-model.cpp
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread src/ivcam/sr300.cpp Outdated
Comment thread common/fw/firmware-version.h Outdated
Comment thread src/ivcam/sr300.cpp

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp
ev-mp merged commit df2c793 into realsenseai:development Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants