Skip to content

Implementation of Brown-Conrady model on SSE , CUDA and GLSL - #8759

Merged
maloel merged 8 commits into
realsenseai:brown-conradyfrom
aangerma:my-brown-conrady
Apr 11, 2021
Merged

Implementation of Brown-Conrady model on SSE , CUDA and GLSL#8759
maloel merged 8 commits into
realsenseai:brown-conradyfrom
aangerma:my-brown-conrady

Conversation

@aangerma

@aangerma aangerma commented Apr 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Implementation of Brown-Conrady transformation on deproject_pixel_to_point_cuda().
  2. Fix of Inverse-Brown-Conrady transformation on deproject_pixel_to_point_cuda().
  3. Implementation of Brown-Conrady transformation on get_texture_map_sse().
  4. Added unit tests for sse code (Inverse-Brown and Brown).
  5. Added unit tests for cuda code (Inverse-Brown and Brown).
  6. Implementation of Brown-Conrady transformation on GLSL.

@aangerma aangerma changed the title Set distortion model of color on L515 to RS2_DISTORTION_BROWN_CONRADY Implementation of Brown-Conrady model on SSE and CUDA Apr 6, 2021
@aangerma aangerma changed the title Implementation of Brown-Conrady model on SSE and CUDA Implementation of Brown-Conrady model on SSE , CUDA and GLSL Apr 8, 2021
maloel
maloel reviewed Apr 8, 2021
View reviewed changes
Comment thread src/cuda/cuda-pointcloud.cu Outdated
@maloel maloel closed this Apr 8, 2021
@maloel maloel reopened this Apr 8, 2021
@maloel maloel closed this Apr 8, 2021
@maloel maloel reopened this Apr 8, 2021
@aangerma
1. fixed warnings.
2dd4c82 
2. fixed sse crash.
maloel
maloel reviewed Apr 11, 2021
View reviewed changes
Comment thread unit-tests/algo/projection/test-distortion.cpp Outdated
compare(pixel1, pixel2);
}

#ifdef __SSSE3__

@maloel maloel Apr 11, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why SSE3? That's the only thing we work with?

@aangerma aangerma Apr 11, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are specifically for SSE.

maloel
maloel reviewed Apr 11, 2021
View reviewed changes
Comment thread src/gl/pointcloud-gl.cpp Outdated
maloel
maloel reviewed Apr 11, 2021
View reviewed changes
Comment thread unit-tests/algo/projection/test-distortion.cpp Outdated
@maloel
maloel merged commit f0a280e into realsenseai:brown-conrady Apr 11, 2021
@RealSenseSupport RealSenseSupport mentioned this pull request May 3, 2021
Closed
@rafaelspring rafaelspring mentioned this pull request May 25, 2021
Closed
@MartyG-RealSense MartyG-RealSense mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maloel maloel maloel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aangerma @maloel