Fix sr3xx firmware image size and recovery checks - #8876
Merged
Conversation
ev-mp
force-pushed
the
sr3xx_fix
branch
2 times, most recently
from
April 21, 2021 14:46
8c13db9 to
42641e8
Compare
maloel
reviewed
Apr 28, 2021
| VALIDATE_FIXED_SIZE(image_size, unsigned_fw_size); // check if the given FW size matches the expected FW size | ||
| // check if the given FW size matches the expected FW size | ||
| auto fw_image_sz = { unsigned_fw_size, unsigned_sr300_size }; | ||
| if (std::find(fw_image_sz.begin(), fw_image_sz.end(), image_size) == fw_image_sz.end()) |
Contributor
There was a problem hiding this comment.
That's three times now... maybe this should be abstracted into a helper function?
maloel
approved these changes
Apr 28, 2021
maloel
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but see my comment
added 2 commits
May 12, 2021 09:24
Modify SR3xx recovery type to be based on PID only (MF classes has changed as of build 1909)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust recognized FW sizes for SR3xx
Modify SR3xx recovery device condition for Win10 1909
Tracked on DSO-16985