Skip to content

fix CppCheck warning in string-utilities.h - #9209

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:cppcheck
Jun 14, 2021
Merged

fix CppCheck warning in string-utilities.h#9209
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:cppcheck

Conversation

@maloel

@maloel maloel commented Jun 12, 2021

Copy link
Copy Markdown
Contributor
common\utilities\string\string-utilities.h:118:26: error: Uninitialized variable: last_char_idx [uninitvar]
    return str.size() == last_char_idx; // all the chars in the string are converted to the value (thus there are no other chars other than numbers)
                         ^

last_char_idx was uninitialized.
The file has a ton of tabs, too -- clang'ed it, sorry :)

@maloel
maloel requested a review from Nir-Az June 12, 2021 11:41

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maloel
maloel merged commit 3f57579 into realsenseai:development Jun 14, 2021
@maloel
maloel deleted the cppcheck branch December 22, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants