D400 Calibration extensions in C# - #9256
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
remibettan
reviewed
Jun 20, 2021
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Great work - few comments added
using each Depth profile, which available for device performs next 16 calibration combinations (in case of windows otherwise 8):
CalibrationSpeed
VeryFast, // (0.66 seconds), for small depth degradation
Fast, // (1.33 seconds), medium depth degradation.This is the recommended setting.
Medium, // (2.84 seconds), medium depth degradation.
Slow, // (Default) (2.84 seconds), for significant depth degradation.
CalibrationScanParameter
Intrinsic, // (default) Intrinsic calibration correction. The intrinsic distortion comes about through microscopic shifts in the lens positions
Extrinsic, // Extrinsic calibration correction. Extrinsic distortions are related to microscopic bending and twisting of the stiffener on which the two stereo sensors are mounted
CalibrationDataSampling
WindowsAndLinux,// default is 0 which uses a polling approach that works on Windows and Linux
Windows, // Windows it is possible to select 1 which is interrupt data sampling which is slightly faster
Test calibration report will be written to the file ReportTestCalibrationModes.csv in application working directory
Change-Id: I6003907fd8d48fe6b397b521ec3e5dc8da3b5d4d
Change-Id: Ie861e9a14b42ddf8696c9567d5b8439a05fb2ca5
Remove unused var. Change-Id: I528b24e0d63c0304cedcad645baeefc0d7580b41
Change-Id: I2b00c9420cd511e77cd646a3e7628da83010ba4e
Change-Id: I9c89a91797b96b41006e0fed8263fc485920e916
maloel
reviewed
Jul 4, 2021
maloel
reviewed
Jul 4, 2021
maloel
reviewed
Jul 4, 2021
maloel
reviewed
Jul 4, 2021
maloel
approved these changes
Jul 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on @DenisGeek's work in #8773