Drop static from func signature - #9379
Merged
Merged
Conversation
maloel
reviewed
Jul 14, 2021
maloel
reviewed
Jul 14, 2021
maloel
reviewed
Jul 14, 2021
| } | ||
| HANDLE_EXCEPTIONS_AND_RETURN(nullptr, terminal_parser, command, response) | ||
|
|
||
| void rs2_project_point_to_pixel(float pixel[2], const struct rs2_intrinsics* intrin, const float point[3]) BEGIN_API_CALL |
Contributor
There was a problem hiding this comment.
Why here? I suggest you move them to a new rsutil.cpp.
Contributor
Author
There was a problem hiding this comment.
The implementation for all public APIs is in a single file
Contributor
There was a problem hiding this comment.
If we see fit to separate in a header, we can separate in a different .cpp
maloel
reviewed
Jul 14, 2021
maloel
reviewed
Jul 14, 2021
remove redundant file
added empty line
Change-Id: Ibfba0dbdba960f3fac5fa1622f3bf3a5fe3a9d23
Change-Id: I1fa8a78f58fcb6c29ffe789e48897e4ef1df8c1b
…and removed from the other references Change-Id: I9b61c3bcdcee06187deb997182b195cb2c60598d
Change-Id: I11ff7a135f1d12d6d7f6964cb3126538c1857b3c
Change-Id: I10cf5ba856fac2dd22154de71f0ac6464d0475bd
maloel
reviewed
Jul 14, 2021
| pixel[1] = y * intrin->fy + intrin->ppy; | ||
| } | ||
| NOEXCEPT_RETURN(, intrin) | ||
| NOEXCEPT_RETURN(, pixel) |
Contributor
There was a problem hiding this comment.
Doesn't this mean only pixel will get output on error?
maloel
reviewed
Jul 14, 2021
| NOEXCEPT_RETURN(, to_fov) | ||
|
|
||
| /* Helper inner function (not part of the API) */ | ||
| void next_pixel_in_line(float curr[2], const float start[2], const float end[2]) |
Contributor
There was a problem hiding this comment.
These should probably be static or in an unnamed namespace
maloel
approved these changes
Jul 14, 2021
maloel
left a comment
Contributor
There was a problem hiding this comment.
I still think we shouldn't have a monolithic rs.cpp, but up to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #9096. Addresses #6055
Tracked on: DSO-17046