Skip to content

Fix playback deadlock on live tests (Git Actions CI fail) - #9394

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
Nir-Az:test_gh_actions_timeout
Jul 15, 2021
Merged

Fix playback deadlock on live tests (Git Actions CI fail)#9394
maloel merged 1 commit into
realsenseai:developmentfrom
Nir-Az:test_gh_actions_timeout

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Jul 14, 2021

Copy link
Copy Markdown
Collaborator
  • Bring back playback sensor flush on end-of-file or else last frames may get lost
  • Move sensor stop outside of mutex lock
  • Fix 2 unit-tests that did not stop & close the sensors

Tracked on [LRS-190]

@Nir-Az
Nir-Az requested a review from maloel July 14, 2021 16:22

@maloel maloel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about the testing before I merge...

@Nir-Az

Nir-Az commented Jul 15, 2021

Copy link
Copy Markdown
Collaborator Author

Let's talk about the testing before I merge...

Tests done:

  • libCI nightly x1 - pass
  • GH actions x5 - pass
  • Viewer free play on playback - pass

@maloel
maloel merged commit 1b87d4b into realsenseai:development Jul 15, 2021
@maloel

maloel commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

@Nir-Az
Nir-Az deleted the test_gh_actions_timeout branch July 27, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants