Update preset json format + Add device info - #9465

Merged

maloel merged 19 commits into

realsenseai:developmentfrom

Nir-Az:add_camera_source_to_json

Jul 22, 2021

Nir-Az commented Jul 22, 2021 •

edited

Loading

Collaborator

Change preset json format to SCHEMA_VERSION = 1
Reading backward compatible - old style (flat) preset json files is supported

Tracked on [LRS-210]

Nir-Az added 9 commits

July 18, 2021 13:56


          update tooltip text to refer to non stereo devices

bb52262


          add serialized device info data

12e4d6c


          implement load

c7a2e95


          redesign

e339036


          add write header support

d88305a


          implement writer & D400 support

682fdda


          rename files

9d9dcec


          add viewer write-read support

5ba3bd1


          override device info for d400

d728ad9

Nir-Az requested review from ev-mp and maloel

July 22, 2021 07:19


          add comments to classes API

bf3eb5f

Nir-Az force-pushed the add_camera_source_to_json branch from d1b63d6 to bf3eb5f Compare

July 22, 2021 07:36

maloel reviewed

View reviewed changes

src/ds5/advanced_mode/json_loader.hpp

maloel reviewed

View reviewed changes

src/ds5/advanced_mode/json_loader.hpp Outdated

                       }
-                      auto str = j.dump(4);
+                      auto str = preset_writer.get_root().dump(4);

maloel Jul 22, 2021

Contributor

Shouldn't we have something like a to_string() call for the writer?

Nir-Az Jul 22, 2021

Collaborator Author

good idea 👍

maloel reviewed

View reviewed changes

src/serialized-utilities.h

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

Nir-Az added 2 commits

July 22, 2021 11:09


          add to_string() function

f9a7200


          replace tabs with spaces

20f0609

maloel reviewed

View reviewed changes

src/ds5/advanced_mode/json_loader.hpp Outdated

maloel reviewed

View reviewed changes

src/ds5/advanced_mode/json_loader.hpp Outdated

maloel reviewed

View reviewed changes

src/l500/l500-serializable.cpp Outdated

maloel reviewed

View reviewed changes

src/l500/l500-serializable.cpp Outdated

Nir-Az added 3 commits

July 22, 2021 12:07


          change return value to const&

c45c0b1


          add const to SCHEMA_VERSION

6b7207e


          CR fixes

d0651e9

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp Outdated

maloel reviewed

View reviewed changes

src/serialized-utilities.h Outdated

Nir-Az added 3 commits

July 22, 2021 13:03


          namespace fixes

a165986


          enforce schema version

291fb41


          refactor validate_schema

41a92bc

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp

maloel reviewed

View reviewed changes

src/serialized-utilities.cpp


          fix fw version validation

42bdec7

maloel approved these changes

View reviewed changes

maloel merged commit e69cd66 into realsenseai:development

Nir-Az deleted the add_camera_source_to_json branch

July 27, 2021 12:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet