pointcloud-stitching demo - #9558
Merged
Merged
Conversation
Fill depth and color for previous closer pixel with no valid color.
Add button to save infrared images to be used in calibration process.
Fix issue fill depth even if no color available.
fix display of depth value
Fix _soft_dev sensors fps to realistic 10 so that the syncer will not dump the stitched depth frame.
Init window size according to available resolution.
…ation images (no input depth stream was defined) Quit if connected using usb2.0 connection type. save calibration images to calibration_input directory inside workspace. Record into given workspace directory
doronhi
marked this pull request as draft
August 3, 2021 08:35
ev-mp
suggested changes
Aug 3, 2021
doronhi
commented
Aug 5, 2021
doronhi
left a comment
Contributor
Author
There was a problem hiding this comment.
Fixed. For some of the changes, I would like your approval.
| There is no hard limitation on the values given to the virtual device. | ||
| Some notes to bear in mind for appearance: | ||
| - Areas in the virtual device's FOV that are not covered by actual devices create empty spaces in the image. | ||
| - Try to maintain the same width-height ration for color and depth images. |
Contributor
Author
There was a problem hiding this comment.
Yes, they will be rectangular but this is not a hard limitation on the demo. A user can choose whatever seems nicer to them. I played around a little to find a visually pleasing result. If I came up with a strict rule that should be observed I would enforce it in the code or better yet, allow the user to set only part of the list and make the program fill the rest.
fix relative link
fix link to pc-stitching demo movie.
fixed video links
ev-mp
marked this pull request as ready for review
August 9, 2021 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wrapper/pointcloud/pointcloud-stitching/rs-pointcloud-stitching demo.
The demo combines 2 devices into a wide FOV virtual device.
The method used to stitch the images is to transfer both pointclouds into the virtual device's coordinate system and then project them on the virtual device's images.
The app assumes the calibration matrix between the devices is known. A method for calculating it is demonstrated in the wrappers\pointcloud\pointcloud-stitching\doc\pointcloud-stitching-demo.md file.