Updating presets - #9642
Merged
Merged
Conversation
ev-mp
reviewed
Aug 17, 2021
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, waiting for a confirmation with IQ before merge
ev-mp
reviewed
Aug 24, 2021
tomerashuach
force-pushed
the
depth_fill_17183
branch
from
August 31, 2021 12:50
e0fdb31 to
326467a
Compare
ev-mp
suggested changes
Sep 9, 2021
| default_450(p); | ||
| break; | ||
| //case ds::RS455_PID: | ||
| case ds::RS435I_PID: |
ev-mp
marked this pull request as ready for review
September 13, 2021 06:29
ev-mp
suggested changes
Sep 13, 2021
tomerashuach
force-pushed
the
depth_fill_17183
branch
from
September 13, 2021 13:05
b47e624 to
041deaf
Compare
added 12 commits
September 19, 2021 09:54
…s in advanced_mode.hpp
Contributor
|
Go over MSVC warnings |
tomerashuach
force-pushed
the
depth_fill_17183
branch
from
September 22, 2021 05:53
041deaf to
da90cae
Compare
tomerashuach
force-pushed
the
depth_fill_17183
branch
from
September 22, 2021 08:04
da90cae to
e412aa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated hard-coded presets.
Added a D450 preset.
Updated the function that chooses the correct presets.
Tested by comparing the JSONs files of the new presets (in the ticket) to the exported JSONs files from the viewer.
Edit: I have added a fix for the inaccuracy of setting an int field in the SDK with a float value from the json preset.
Edit2: added two resolutions based presets to D455 as solutions for DSO-17597.
Tracked on DSO-17183.