Android fix dso 14436 [Android] RS Camera viewer restarts the stream when rotating screen. - #9662
Merged
Merged
Conversation
remibettan
reviewed
Aug 24, 2021
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Please confirm you have tried it and stream does not stop when changing orientation (in Preview, Record and Playback.
Please change the method name setup_controls to setupControls.
Contributor
Author
|
@remibettan yes, checked in debugger/logcat and other means, stream does not stop during orientation change. in preview, the stream duration timestamp shows it continuous. in recording, a single file is generated instead of multiple since there is no session stop/restart. similarly, in plackback, it's also continuous. method rename done. |
ev-mp
approved these changes
Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Tracked on: DSO-14436